Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Revert "WebpackBuilder: Remove need for react as peerDependency" #23882

Merged

Conversation

vanessayuenn
Copy link
Contributor

@vanessayuenn vanessayuenn commented Aug 18, 2023

Reverts #23496.
Resolves #23876

🦋 Canary release

This pull request has been released as version 0.0.0-pr-23882-sha-6c4dd3dd. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-23882-sha-6c4dd3dd
Triggered by @yannbf
Repository storybookjs/storybook
Branch revert-23496-norbert/react-peerdep-webpack-builder-removal
Commit 6c4dd3dd
Datetime Fri Aug 18 11:23:58 UTC 2023 (1692357838)
Workflow run 5902057114

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=23882

@vanessayuenn vanessayuenn added the ci:daily Run the CI jobs that normally run in the daily job. label Aug 18, 2023
@yannbf yannbf changed the title Revert "WebpackBuilder: Remove need for react as peerDependency" Maintenance: Revert "WebpackBuilder: Remove need for react as peerDependency" Aug 18, 2023
@yannbf yannbf added maintenance User-facing maintenance tasks patch:yes Bugfix & documentation PR that need to be picked to main branch labels Aug 18, 2023
@yannbf yannbf merged commit 946ea82 into next Aug 18, 2023
102 of 107 checks passed
@yannbf yannbf deleted the revert-23496-norbert/react-peerdep-webpack-builder-removal branch August 18, 2023 13:24
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
20 tasks
storybook-bot pushed a commit that referenced this pull request Aug 18, 2023
…-peerdep-webpack-builder-removal

Maintenance: Revert "WebpackBuilder: Remove need for `react` as peerDependency"
(cherry picked from commit 946ea82)
@github-actions github-actions bot mentioned this pull request Aug 18, 2023
3 tasks
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Aug 18, 2023
@ndelangen ndelangen self-assigned this Aug 21, 2023
@ndelangen ndelangen restored the revert-23496-norbert/react-peerdep-webpack-builder-removal branch August 21, 2023 06:40
@github-actions github-actions bot mentioned this pull request Aug 23, 2023
22 tasks
@ndelangen ndelangen deleted the revert-23496-norbert/react-peerdep-webpack-builder-removal branch October 20, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/react-webpack5 v7.3 crashes without @storybook/manager-api
3 participants