Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Create @storybook/test package based on vitest #24392

Merged
merged 45 commits into from Oct 27, 2023

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Oct 5, 2023

Closes #24171

What I did

See the issue

How to test

I added some more unit tests, but this needs some more tests before being merged.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "build", "documentation", "maintenance", "dependencies", "other"]

🦋 Canary release

This pull request has been released as version 0.0.0-pr-24392-sha-bcf87ea5. Install it by pinning all your Storybook dependencies to that version.

More information
Published version 0.0.0-pr-24392-sha-bcf87ea5
Triggered by @kasperpeulen
Repository storybookjs/storybook
Branch kapser/test-package2
Commit bcf87ea5
Datetime Fri Oct 27 08:46:39 UTC 2023 (1698396399)
Workflow run 6664979846

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24392

@socket-security
Copy link

socket-security bot commented Oct 5, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@vitest/spy 0.34.7 None +2 42.5 kB oreanno
@vitest/utils 0.34.7 None +4 243 kB oreanno
@types/chai 4.3.6 None +0 77.5 kB types
@vitest/expect 0.34.5 None +20 2.14 MB oreanno
@types/jest 29.5.6 None +0 77.9 kB types
chai 4.3.10 environment +6 879 kB keithamus

@socket-security
Copy link

socket-security bot commented Oct 5, 2023

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: pathval@1.1.1, check-error@1.0.3

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@kasperpeulen kasperpeulen added ci:daily Run the CI jobs that normally run in the daily job. feature request labels Oct 5, 2023
@kasperpeulen
Copy link
Contributor Author

@SocketSecurity ignore-all

@kasperpeulen kasperpeulen added ci:merged Run the CI jobs that normally run when merged. and removed ci:daily Run the CI jobs that normally run in the daily job. labels Oct 27, 2023
@kasperpeulen kasperpeulen merged commit e1bcbfe into next Oct 27, 2023
71 checks passed
@kasperpeulen kasperpeulen deleted the kapser/test-package2 branch October 27, 2023 14:54
@IanVS
Copy link
Member

IanVS commented Oct 27, 2023

\o/ Nice work, can't wait to try it out.

I didn't review very closely, but one thing I did notice is that this new package does not have a README, should it? Might be nice for those visiting its NPM page, and sometimes pages in Storybook docs link to package READMEs, I think.

@kasperpeulen
Copy link
Contributor Author

@IanVS We are also working on the docs!

#24263

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:merged Run the CI jobs that normally run when merged. feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release @storybook/test officially
5 participants