CLI: Use @storybook/test in template stories #24393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
added
ci: do not merge
cli
ci:daily
yannbf
requested review from
kasperpeulen,
JReinhold,
valentinpalkovic and
ndelangen
as code owners
|
@kasperpeulen it seems like using This PR updates only the CLI templates, but because our sandboxes are augmented with extra stories so we can test them via E2E, things fail as those stories use @storybook/jest. 😵 We can update everything, but we'll end up not testing @storybook/jest and @storybook/testing-library anymore this way. |
kasperpeulen
force-pushed
the
kapser/test-package2
branch
from
000505a
to
4f08e77
Compare
kasperpeulen
force-pushed
the
yann/use-test-package-in-template-stories
branch
from
d0e4a2a
to
11d1e03
Compare
kasperpeulen
force-pushed
the
yann/use-test-package-in-template-stories
branch
from
d6d2600
to
c33b724
Compare
kasperpeulen
added
ci:merged
|
@yannbf can this be merged? |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24172
What I did
This PR replaces the usage of
@storybook/testing-librarywith the new@storybook/testpackage, which includes the same utilities.Because it also includes other utilities such as
expect, the play functions are also updated to use theexpect.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
yarn task --task sandbox --start-from auto --template react-vite/default-tsDocumentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>