Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Fix horizontal scroll bar in Canvas hidden by styling #24408

Merged

Conversation

yoshi2no
Copy link
Contributor

@yoshi2no yoshi2no commented Oct 9, 2023

Closes #24226

What I did

  • remove negative margin from ChildrenContainer in code/ui/blocks/src/components/Preview.tsx
    • This bug was happening when the layout wascentred, orpadded.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

  1. Run a sandbox for template nextjs-default-ts
  2. Set width to in sandbox/nextjs-default-ts/stories/Header.tsx (for scrolling) like this
<header style={{width: "1200px"}}></header>
  1. Temporarily set the layout of sandbox/nextjs-default-ts/stories/Header.stories.ts to padded or centered.
const meta = {
  // omitted
  parameters: {
    layout: 'centered', // or 'padded'
  },
} satisfies Meta<typeof Header>;
  1. Open Storybook in your browser
  2. Access story http://localhost:6006/?path=/docs/example-header--docs

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@cdedreuille cdedreuille self-assigned this Oct 9, 2023
@cdedreuille cdedreuille added maintenance User-facing maintenance tasks ci:normal labels Oct 9, 2023
@cdedreuille cdedreuille changed the title fix: Horizontal scroll bar in Canvas hidden by styling UI: Horizontal scroll bar in Canvas hidden by styling Nov 7, 2023
@cdedreuille cdedreuille changed the title UI: Horizontal scroll bar in Canvas hidden by styling UI: Fix horizontal scroll bar in Canvas hidden by styling Nov 7, 2023
Copy link
Contributor

@cdedreuille cdedreuille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing it, I'm not sure this is the right solution.

Copy link
Contributor

@cdedreuille cdedreuille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it does work. I'll accept it again :) The changes pushes the content 10px more inside the canvas which is quite a big change but it also fixes the problem of having the button "Show code" overlapping on the content. If we update the placement of this button in the future, we might be able to reduce the paddings again.

Thanks a lot for making that change @yoshi2no

@cdedreuille cdedreuille merged commit de2e9b8 into storybookjs:next Nov 7, 2023
49 of 51 checks passed
@github-actions github-actions bot mentioned this pull request Nov 7, 2023
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Horizontal scroll bar in Canvas hidden by styling
2 participants