Angular: update wrong type for webpackStatsJson in start-storybook schema.json

[LucaVazz]

Closes #24512

What I did

In Storybook 7.5.0, the schema for start-storybook has a wrong type set for the webpackStatsJson property.

Either the type needs to be adapted or the default value should be changed / removed.

I went with changing the type, as...:

• the ["boolean", "string"] type is also specified in the scheme for build-storybook:
  https://github.com/storybookjs/storybook/blob/next/code/frameworks/angular/src/builders/build-storybook/schema.json#L65
• the string | boolean type is also defined in the CLIOptions interface inside core-common.ts:
  https://github.com/storybookjs/storybook/blob/next/code/lib/types/src/modules/core-common.ts#L160

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

• stories
• unit tests
• integration tests
• end-to-end tests

Not covered by automated tests as far as I can tell

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

To be honest I'm not sure how to test this isolated... When starting storybook trough the CLI I can't reproduce this error, it only occurs for me when starting storybook via nx.

(Taken from the PR which introduced the property into the scheme: #24388)

1. Run a sandbox for an angular template, e.g. yarn task --task sandbox --start-from auto --template angular-cli/default-ts
2. Try the new flags on both build and dev

Documentation

• Add or update documentation reflecting your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Checklist for Maintainers

• When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

• Make sure this PR contains one of the labels below:

  Available labels

  • bug: Internal changes that fixes incorrect behavior.
  • maintenance: User-facing maintenance tasks.
  • dependencies: Upgrading (sometimes downgrading) dependencies.
  • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
  • cleanup: Minor cleanup style change. Will not show up in release changelog.
  • documentation: Documentation only changes. Will not show up in release changelog.
  • feature request: Introducing a new feature.
  • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
  • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

[mandarini]

Came here to say that our e2e tests failed due to that! And it was already fixed!!! Magic <3 <3 <3

[LucaVazz]

@mandarini In case you are also using nx: I've found a workaround until the new storybook version is released, you can adapt your project.json as follows:

{
  "name": "storybook",
  "$schema": "../node_modules/nx/schemas/project-schema.json",
  // ...
  "targets": {
    "serve": {
      // ...
      "options": {
        // ...
        "webpackStatsJson": "" // 👈 workaround, has the same effect as false but does not trigger type error
      }
    }
  }
}

[mandarini]

Thank you!!!!

[LucaVazz]

Thank you @valentinpalkovic for the fast merge and patch version release 🎉