Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actions: Fix missing crypto module crashing React Native #24546

Merged
merged 1 commit into from Oct 22, 2023

Conversation

dannyhw
Copy link
Member

@dannyhw dannyhw commented Oct 22, 2023

Closes #

What I did

When implementing v7 for react native I found that actions would crash the app because crypto is missing.
I've added a check for crypto.

@shilman @ndelangen

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This is only really testable in React Native, but getting the 7.0 branch setup is non-trivial so I'm skipping this.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman changed the title Actions: Fix using uuidv4 crashes react native because of missing crypto module Actions: Fix missing crypto module crashing React Native Oct 22, 2023
@shilman shilman merged commit ea8dd8e into next Oct 22, 2023
59 of 66 checks passed
@shilman shilman deleted the dannyhw/fix-actions-get-id-crashes-react-native branch October 22, 2023 12:31
@github-actions github-actions bot mentioned this pull request Oct 22, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants