Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport: Add newer device viewports #24777

Merged
merged 2 commits into from Nov 14, 2023

Conversation

Tomo5524
Copy link
Contributor

@Tomo5524 Tomo5524 commented Nov 9, 2023

What I did

This pull request introduces updates to the INITIAL_VIEWPORTS configuration in Storybook. The aim of these changes is to ensure that the Storybook environment stays current with the devices used for UI display, which are relevant in the current industry standards.

The updated INITIAL_VIEWPORTS configuration now includes the following devices:

  • iPad Pro 11-in
  • iPhone 14 Pro Max
  • iPhone 14 Pro
  • iPhone 14
  • iPhone 13 Pro Max
  • iPhone 13 Pro
  • iPhone 13
  • iPhone SE 3rd generation

These additions to the INITIAL_VIEWPORTS configuration are essential for maintaining alignment with current industry standards. They ensure that stakeholders have a clear understanding of the devices utilized for showcasing user interfaces within Storybook.

before after
https://github.com/storybookjs/storybook/assets/57059705/9ed4f961-353b-4b77-a051-efe550cdecc1 https://github.com/storybookjs/storybook/assets/57059705/12be530b-642c-4a80-8e15-7ee0ae132dbd

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

Ran sandbox locally and verified all the added devices are working as expected.

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

馃 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@shilman shilman changed the title Addon Viewport: added newer devices viewport Viewport: Add newer device viewports Nov 13, 2023
@ndelangen
Copy link
Member

I'll add this for 7.x, but kinda want to reduce this list if not entirely remove it from our codebase, perhaps in 8.0.

We can't have this list grow to infinity, and it's included into the bundle even if left unused.

@ndelangen ndelangen merged commit 837936a into storybookjs:next Nov 14, 2023
55 of 60 checks passed
@github-actions github-actions bot mentioned this pull request Nov 14, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants