Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused dependencies #2480

Merged
merged 7 commits into from Dec 14, 2017
Merged

Remove unused dependencies #2480

merged 7 commits into from Dec 14, 2017

Conversation

Hypnosphi
Copy link
Member

Fixes #2470 and fixes #2471

@Hypnosphi Hypnosphi added cleanup Minor cleanup style change that won't show up in release changelog dependencies maintenance User-facing maintenance tasks labels Dec 13, 2017
@codecov
Copy link

codecov bot commented Dec 13, 2017

Codecov Report

Merging #2480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2480   +/-   ##
=======================================
  Coverage   16.87%   16.87%           
=======================================
  Files         307      307           
  Lines        7792     7792           
  Branches      786      787    +1     
=======================================
  Hits         1315     1315           
+ Misses       5828     5820    -8     
- Partials      649      657    +8
Impacted Files Coverage Δ
app/react-native/src/preview/story_kind.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/search_box.js 32.94% <0%> (ø) ⬆️
...mments/src/manager/components/CommentItem/index.js 0% <0%> (ø) ⬆️
...s/left_panel/stories_tree/tree_decorators_utils.js 45.23% <0%> (ø) ⬆️
app/react/src/demo/Welcome.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 6.25% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/routed_link.js 21.15% <0%> (ø) ⬆️
addons/a11y/src/components/Report/Item.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
...b/ui/src/modules/ui/components/left_panel/index.js 18.51% <0%> (ø) ⬆️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84f4ba6...1415f6f. Read the comment docs.

Copy link
Member

@ndelangen ndelangen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen
Copy link
Member

Merge when ready 👍

@Hypnosphi Hypnosphi self-assigned this Dec 14, 2017
@Hypnosphi Hypnosphi merged commit 444d993 into master Dec 14, 2017
@Hypnosphi Hypnosphi deleted the remove-unused-deps branch December 14, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup Minor cleanup style change that won't show up in release changelog dependencies maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants