Webpack5: Fix race condition for export-order loader #24817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
builder-webpack5
ci:daily
|
New dependencies detected. Learn more about Socket for GitHub 鈫楋笌
|
valentinpalkovic
force-pushed
the
valentin/fix-race-condition-for-export-order-loader
branch
from
5f2d25a
to
80211d8
Compare
JReinhold
approved these changes
Nov 12, 2023
Comment on lines
11
to
12
| // eslint-disable-next-line @typescript-eslint/naming-convention | ||
| const [_, exports] = parse(source); | ||
| const [_, exports = []] = await parse(source); |
There was a problem hiding this comment.
FYI you can do const [, exports = []] = ... to skip the first entry, and to remove the lint error.
valentinpalkovic
force-pushed
the
valentin/fix-race-condition-for-export-order-loader
branch
from
80211d8
to
a6804fd
Compare
valentinpalkovic
force-pushed
the
valentin/fix-race-condition-for-export-order-loader
branch
from
a6804fd
to
b90ee0e
Compare
valentinpalkovic
deleted the
valentin/fix-race-condition-for-export-order-loader
branch
30 tasks
kasperpeulen
restored the
valentin/fix-race-condition-for-export-order-loader
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes N/A
What I did
The newly implemented export-order loader seems to fail randomly. The
parsefunction ofes-module-lexerhas to be awaited to wait forwasmbeing ready.Besides that:
enforce: 'post'option like it is done in the Vite builderChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
That is not really possible. I will reran CI to see, whether the random error occurs
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.馃 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>