Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addons, core: Make react and Storybook packages devDependencies where possible - ATTEMPT 2 #24834

Merged
merged 5 commits into from Nov 15, 2023
Merged

Addons, core: Make react and Storybook packages devDependencies where possible - ATTEMPT 2 #24834

merged 5 commits into from Nov 15, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Nov 14, 2023 •
edited

Re-attempt #24676 (reverted in #24832).

Mistakes fixed in #24841 that merges into this PR.

@JReinhold JReinhold self-assigned this Nov 14, 2023
@JReinhold JReinhold mentioned this pull request Nov 14, 2023
Merged
8 tasks
JReinhold and others added 2 commits November 15, 2023 10:12
@socket-security Socket Security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@storybook/theming 7.4.6...7.5.0 None +0/-0 724 kB shilman
@storybook/client-logger 7.4.6...7.5.0 None +0/-0 7.45 kB shilman

@JReinhold JReinhold marked this pull request as ready for review November 15, 2023 13:10
@JReinhold JReinhold merged commit df35702 into next Nov 15, 2023
111 of 112 checks passed
@JReinhold JReinhold deleted the revert-24832-revert-24676-experiment-addon-peer-dep branch November 15, 2023 13:54
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
36 tasks
@Mattgic Mattgic mentioned this pull request Nov 24, 2023
Closed
@robertbrignull robertbrignull mentioned this pull request Jan 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen ndelangen approved these changes

@cdedreuille cdedreuille Awaiting requested review from cdedreuille

@tmeasday tmeasday Awaiting requested review from tmeasday

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

@yannbf yannbf Awaiting requested review from yannbf

@valentinpalkovic valentinpalkovic Awaiting requested review from valentinpalkovic

@shilman shilman Awaiting requested review from shilman

@IanVS IanVS Awaiting requested review from IanVS

@ShaunEvening ShaunEvening Awaiting requested review from ShaunEvening

Assignees

@JReinhold JReinhold

Labels
addon: a11y addon: actions addon: backgrounds addon: controls addon: docs addon: essentials addon: highlight addon: interactions addon: links addon: measure addon: outline addon: themes addon: toolbars addon: viewport builder-manager builder-vite builder-webpack5 ci:daily Run the CI jobs that normally run in the daily job. core maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JReinhold @ndelangen