Test: Model loaders as before each and restore mocks properly #24948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperpeulen
requested review from
cdedreuille,
JReinhold,
shilman,
valentinpalkovic,
ndelangen and
yannbf
as code owners
|
No top level dependency changes detected. Learn more about Socket for GitHub ↗︎ |
shilman
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Great job pulling this together @kasperpeulen. What's the release plan with @storybook/csf?
yannbf
reviewed
Nov 22, 2023
yannbf
reviewed
Nov 22, 2023
yannbf
reviewed
Nov 22, 2023
yannbf
reviewed
Nov 22, 2023
ndelangen
requested changes
Nov 22, 2023
IanVS
reviewed
Nov 22, 2023
When I have CI green, and did some more QA, I think I will release csf to stable. |
…ach' into kasper/model-loaders-as-before-each
…ach' into kasper/model-loaders-as-before-each
kasperpeulen
force-pushed
the
kasper/model-loaders-as-before-each
branch
from
11dce16
to
12960c7
Compare
36 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Model loaders as before each and restore mocks properly
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-24948-sha-12960c76. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-24948-sha-12960c76kasper/model-loaders-as-before-each12960c761700670240)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=24948