SvelteKit: Support 2.0 modules with mocks #25244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paoloricciuti
requested review from
yannbf,
valentinpalkovic,
kasperpeulen and
JReinhold
as code owners
|
No top level dependency changes detected. Learn more about Socket for GitHub 鈫楋笌 |
JReinhold
requested changes
Dec 15, 2023
JReinhold
added
feature request
ci:daily
JReinhold
changed the title
JReinhold
added
the
patch:yes
This was referenced Dec 19, 2023
Merged
JReinhold
added a commit
that referenced
this pull request
Dec 19, 2023
SvelteKit: Support 2.0 modules with mocks (cherry picked from commit aae68d4)
github-actions
bot
added
the
patch:done
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added the newly introduced exports from
$app/navigationto the importable and mockable functions in sveltekit.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
yarn task --task sandbox --start-from auto --template svelte-kit/skeleton-tssveltekit/modules/navigationfolderreplaceStateorpushStatebutton-->
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.馃 Canary release
This pull request has been released as version
0.0.0-pr-25244-sha-bd2cf8e0. Install it by pinning all your Storybook dependencies to that version.More information
0.0.0-pr-25244-sha-bd2cf8e0new-sveltekit-modulesbd2cf8e01702904409)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=25244