Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix migration guide scripts #26541

Merged

Conversation

AriPerkkio
Copy link
Contributor

What I did

Fixed migration guide scripts so that they can be run in terminal when copied. The should be ".

image

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Copy link

nx-cloud bot commented Mar 17, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dc825d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@jonniebigodes jonniebigodes self-assigned this Mar 25, 2024
@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 25, 2024
@jonniebigodes
Copy link
Contributor

@AriPerkkio thanks for taking the time to put together this pull request and helping us improve our documentation by catching this small issue. We appreciate it 🙏 ! I've checked, and all is good on my end and going to merge this once the checklist clears.

Have a fantastic week.

Stay safe

@jonniebigodes jonniebigodes merged commit 2b1058d into storybookjs:next Mar 25, 2024
9 checks passed
@AriPerkkio AriPerkkio deleted the docs/migration-guide-scripts branch March 25, 2024 16:44
storybook-bot pushed a commit that referenced this pull request Mar 25, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
storybook-bot pushed a commit that referenced this pull request Mar 26, 2024
Docs: Fix migration guide scripts
(cherry picked from commit 2b1058d)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants