Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Svelte: Fix Vite crashing on virtual module imports #26838

Open
wants to merge 4 commits into
base: next
Choose a base branch
from
+11 −8
Open

Svelte: Fix Vite crashing on virtual module imports #26838

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5e3c4d6
fix: crash on processing virtual module imports
rChaoz Apr 14, 2024
4016817
Correctly fix the thing
rChaoz Apr 15, 2024
6f52ba3
Merge branch 'next' into patch-1
rChaoz Apr 19, 2024
fd9f8a1
Merge branch 'next' into patch-1
JReinhold Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 11 additions & 8 deletions code/frameworks/svelte-vite/src/plugins/svelte-docgen.ts
View file
Open in desktop
Expand Up @@ -100,15 +100,18 @@ export async function svelteDocgen(svelteOptions: Record<string, any> = {}): Pro

let docOptions;
if (docPreprocessOptions) {
const rawSource = fs.readFileSync(resource).toString();

const { code: fileContent } = await preprocess(rawSource, docPreprocessOptions, {
filename: resource,
});
try {
const rawSource = fs.readFileSync(resource).toString();
const { code: fileContent } = await preprocess(rawSource, docPreprocessOptions, {
filename: resource,
})

docOptions = {
fileContent,
};
docOptions = {
fileContent,
}
} catch (_) {
// ignore fail due to virtual module import
}
} else {
docOptions = { filename: resource };
}
Expand Down