Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release: Patch 7.6.18 (manual) #26923

Merged
merged 5 commits into from
Apr 23, 2024
Merged

Release: Patch 7.6.18 (manual) #26923

merged 5 commits into from
Apr 23, 2024

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Apr 23, 2024

Core: Fix addon bundling script
(cherry picked from commit 21a2300)

This is a manual pull request that bumps the version from 7.6.17 to 7.6.18.

It includes the following changes from 8.0.0:

  • 🐛 Bug: Core: Fix addon bundling script #26145

I've tested the reproduction of the original issue against this canary release, and it fixes it too.

CI is failing because of a bug with our Next.js support introduced in 14.2. This has already been fixed in 8.0 by #26874, and I don't intend to backport that fix too. Therefore I consider CI ✅ by https://app.circleci.com/pipelines/github/storybookjs/storybook/75285/workflows/2a4b4f71-e16e-4ced-b53a-e8d3ef0fc71c
(note CI will fail afterwards when I bump the version to 7.6.18 again because that hasn't been released.)

🦋 Canary release

This pull request has been released as version 0.0.0-pr-26923-sha-300a6ba8. Try it out in a new sandbox by running npx storybook@0.0.0-pr-26923-sha-300a6ba8 sandbox or in an existing project with npx storybook@0.0.0-pr-26923-sha-300a6ba8 upgrade.

More information
Published version 0.0.0-pr-26923-sha-300a6ba8
Triggered by @JReinhold
Repository storybookjs/storybook
Branch patch-7-6-18
Commit 300a6ba8
Datetime Tue Apr 23 09:00:26 UTC 2024 (1713862826)
Workflow run 8797678698

To request a new release of this pull request, mention the @storybookjs/core team.

core team members can create a new canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=26923

Core: Fix addon bundling script
(cherry picked from commit 21a2300)
@JReinhold JReinhold self-assigned this Apr 23, 2024
@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. release For PRs that trigger new releases. Automated labels Apr 23, 2024
Copy link

nx-cloud bot commented Apr 23, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5622242. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@JReinhold JReinhold marked this pull request as ready for review April 23, 2024 12:48
@JReinhold JReinhold merged commit 1527c15 into release-7-6 Apr 23, 2024
12 of 20 checks passed
@JReinhold JReinhold deleted the patch-7-6-18 branch April 23, 2024 12:49
@bertpareyn
Copy link

@JReinhold We started (and are still) seeing:

ERR_PNPM_NO_MATCHING_VERSION  No matching version found for @storybook/types@7.6.18

This error happened while installing the dependencies of @storybook/addon-storysource@7.6.18
 at @storybook/source-loader@7.6.18

The latest release of @storybook/types is "8.0.9".

Other releases are:
  * next: 8.1.0-alpha.7
  * future: 7.1.0-alpha.29
  * pr-23508: 7.1.1-pr-23508-1689802571-5ec8c1c3.0
  * pr-22631: 7.1.1-pr-22631-1689802540-351503cb.0
  * canary: 0.0.0-pr-26923-sha-300a6ba8

If you need the full list of all 545 published versions run "$ pnpm view @storybook/types versions".

@JReinhold
Copy link
Contributor Author

@bertpareyn there were some problems during the release, causing only some of the packages to be released.

Should all be fixed now.

@bertpareyn
Copy link

@bertpareyn there were some problems during the release, causing only some of the packages to be released.

Should all be fixed now.

Confirmed fixed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:daily Run the CI jobs that normally run in the daily job. release For PRs that trigger new releases. Automated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants