-
-
Notifications
You must be signed in to change notification settings - Fork 9.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Include @storybook/addon-svelte-csf
when initializing new projects
#27070
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6483a4f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
@manuel3108 @tburny FYI. This was inspired by svelte-compose/svelte-compose#10 and should make it a bit easier to get going with |
@storybook/addon-svelte-csf
@storybook/addon-svelte-csf
@storybook/addon-svelte-csf
when initializing new projects
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Progress towards #21043
What I did
extensions
used in Svelte projects@storybook/addon-svelte-csf
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Tested the CLI tool against a newly initialized Svelte+Vite project and SvelteKit project
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-27070-sha-e0acab3b
. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-27070-sha-e0acab3b sandbox
or in an existing project withnpx storybook@0.0.0-pr-27070-sha-e0acab3b upgrade
.More information
0.0.0-pr-27070-sha-e0acab3b
csf-init
e0acab3b
1715202014
)To request a new release of this pull request, mention the
@storybookjs/core
team.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=27070