Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RE-ADD a 'configureA11Y' which is deprecated for backwards compatibility #5302

Merged
merged 1 commit into from Jan 19, 2019
Merged

RE-ADD a 'configureA11Y' which is deprecated for backwards compatibility #5302

merged 1 commit into from Jan 19, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen added this to the v5.0.0 milestone Jan 19, 2019
@ndelangen ndelangen self-assigned this Jan 19, 2019
tmeasday
tmeasday approved these changes Jan 19, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@codecov
Copy link

codecov bot commented Jan 19, 2019 •
edited

Codecov Report

Merging #5302 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5302      +/-   ##
==========================================
- Coverage   30.08%   30.06%   -0.02%     
==========================================
  Files         619      617       -2     
  Lines        8997     8996       -1     
  Branches     1231     1231              
==========================================
- Hits         2707     2705       -2     
- Misses       5624     5625       +1     
  Partials      666      666
Impacted Files Coverage Δ
addons/a11y/src/index.js 0% <0%> (ø) ⬆️
addons/centered/src/index.js 0% <0%> (ø) ⬆️
addons/centered/vue.js
addons/centered/react.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7712e86...ecaf37a. Read the comment docs.

@ndelangen ndelangen merged commit 4deaf14 into next Jan 19, 2019
@ndelangen ndelangen deleted the fix/deprecate-a11y-confgurationfn branch January 19, 2019 12:21
@shilman shilman mentioned this pull request Jan 20, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@jbovenschen jbovenschen Awaiting requested review from jbovenschen

Assignees

@ndelangen ndelangen

Labels
addon: a11y bug
Projects
None yet
Milestone
v5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ndelangen @tmeasday