Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update modal manager for rn 0.58 support #5581

Merged
merged 2 commits into from Feb 14, 2019
Merged

update modal manager for rn 0.58 support #5581

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c6c463
update modal manager for rn 0.58 support
RWOverdijk Feb 14, 2019
52aa858
FIX lockfile
ndelangen Feb 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/ondevice-knobs/package.json
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@
"prop-types": "^15.6.2",
"react-native-color-picker": "^0.4.0",
"react-native-modal-datetime-picker": "^5.1.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider bumping react-native-modal-datetime-picker too, this will be required for the 0.59 upgrade. If that's too much outside of the scope of this PR I can take a stab at it later.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benoitdion Tomorrow morning 08:00 UTC +1,

We're going on a chaos programming session to fix up Storybook for RN.
@igor-dv and I will be there, and we've invited a few more.

Goal is to get the server part working well again.
Secondary goal would be to upgrade a lot to the latest version, possibly babel etc.

If you'd be interested in helping, you're welcome to join, give advice, possibly learn abit about what's going on in our codebase?

Join our discord and PM me if you want an invite to the Zoom meeting.

Copy link
Member

@ndelangen ndelangen Feb 14, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd LOVE a comprehensive PR upgrading RN to the latest and greatest of all versions!

Please tell me how I can help you make that happen!

"react-native-modal-selector": "^0.0.29",
"react-native-modal-selector": "^1.0.2",
"react-native-switch": "^1.5.0"
},
"peerDependencies": {
Expand Down
7 changes: 4 additions & 3 deletions yarn.lock
View file
Open in desktop
Expand Up @@ -17111,9 +17111,10 @@ react-native-modal-datetime-picker@^5.1.0:
prop-types "^15.6.1"
react-native-modal "^5.4.0"

react-native-modal-selector@^0.0.29:
version "0.0.29"
resolved "https://registry.yarnpkg.com/react-native-modal-selector/-/react-native-modal-selector-0.0.29.tgz#e33326a9191ce6a6ed07c222366eb13ba5e03e21"
react-native-modal-selector@^1.0.2:
version "1.0.2"
resolved "https://registry.yarnpkg.com/react-native-modal-selector/-/react-native-modal-selector-1.0.2.tgz#d6ec94ea9d280162be6c439fea72455479bc5c73"
integrity sha512-nMHwYj5f6brhGC6f+AjZY2BqU3p3TDoqzJJEIMRn7/o27NAvJGE3XS+2J+wfLJstCcYdaDrfYWRWE854KfSHBA==
dependencies:
prop-types "^15.5.10"

Expand Down