Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: remove webpack-env from tsconfig types #8036

Merged
merged 1 commit into from Sep 9, 2019

Conversation

kroeder
Copy link
Member

@kroeder kroeder commented Sep 9, 2019

Issue: #7855

What I did

Removed webpack-env from tsconfig.json in app/angular. I'm not sure why it was added but it seems to work locally plus it removes the tripple-slash reference path from dist which causes the related build issue for all @storybook/angular consumers

How to test

  • Green CI
  • Running app/angular locally
  • Check if the tripple-slash reference is now removed from dist/

@vercel
Copy link

vercel bot commented Sep 9, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@shilman shilman changed the title remove webpack-env from tsconfig types Angular: remove webpack-env from tsconfig types Sep 9, 2019
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Do you know why this was needed? @kroeder @ndelangen

@@ -3,7 +3,7 @@
"compileOnSave": false,
"compilerOptions": {
"outDir": "dist",
"types": ["webpack-env"],
"types": [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's working, that's great, happy to remove this.

@shilman shilman merged commit 5c7f976 into next Sep 9, 2019
@shilman shilman deleted the angular-fix-webpack-env-issue branch September 9, 2019 21:39
@sami616
Copy link

sami616 commented Sep 19, 2019

im seeing the webpack-env build error in my react setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants