Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #9280 from weyert/bugfixes/fix-simplify-issue #9280

Merged
merged 1 commit into from Jan 2, 2020

Conversation

weyert
Copy link
Contributor

@weyert weyert commented Dec 31, 2019

Issue: #9261

A small fix to disable the simplify-feature of the babel's minify plugin as it stops the compilation of the storybook static build.

What I did

I have added the simplify: false-configuration to the babel.js-file

How to test

  • Is this testable with Jest or Chromatic screenshots?
    No
  • Does this need a new example in the kitchen sink apps?
    No
  • Does this need an update to the documentation?
    I am not sure

A small fix to disable the simplify-feature of the babel's minify plugin as it stops the compilation of the storybook static build.
@vercel
Copy link

vercel bot commented Dec 31, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/g7lv4wj2a
✅ Preview: https://monorepo-git-fork-weyert-bugfixes-fix-simplify-issue.storybook.now.sh

@weyert
Copy link
Contributor Author

weyert commented Dec 31, 2019

How did my change cause a change in package-lock.json as suggested?

@shilman shilman changed the title fix: update babel.js to disable simplify Core: Update babel.js to disable simplify Jan 1, 2020
@shilman shilman requested a review from Hypnosphi January 1, 2020 08:57
@shilman
Copy link
Member

shilman commented Jan 1, 2020

Thanks for kicking this off @weyert!! I don't see any change in package-lock.json -- looking good to me.

Since this is a core change, I want to get some feedback on it from members of our core team. @Hypnosphi @tmeasday any thoughts?

@Hypnosphi
Copy link
Member

Hypnosphi commented Jan 1, 2020

LGTM, here's the docs for reference https://github.com/babel/minify/tree/master/packages/babel-plugin-minify-simplify

@shilman please verify that the case from #9077 (comment) works with this change before closing #9077

@shilman shilman changed the title Core: Update babel.js to disable simplify Core: Fix babel.js to disable simplify Jan 2, 2020
@shilman shilman added this to the 5.3.0 milestone Jan 2, 2020
@shilman shilman changed the title Core: Fix babel.js to disable simplify Merge pull request #9280 from weyert/bugfixes/fix-simplify-issue Jan 2, 2020
@shilman shilman merged commit 42eea14 into storybookjs:next Jan 2, 2020
@shilman
Copy link
Member

shilman commented Jan 2, 2020

@Hypnosphi @weyert did not fix #9077 so leaving that open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants