Merge pull request #353 from legobeat/ci-node-versions

Remove Node 14 from engines field
storybookjs · Nov 21, 2023 · 53fdd0f · 53fdd0f
2 parents db1b66a + f52971c
commit 53fdd0f
Show file tree

Hide file tree

Showing 8 changed files with 26 additions and 29 deletions.
diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml
@@ -14,12 +14,12 @@ jobs:
   assert_test_runner:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version-file: .nvmrc
 
       - name: Install dependencies
         uses: bahmutov/npm-install@v1
@@ -36,7 +36,7 @@ jobs:
           YARN_ENABLE_IMMUTABLE_INSTALLS: false
 
       - name: Run test runner
-        uses: mathiasvr/command-output@v1
+        uses: mathiasvr/command-output@v2.0.0
         id: tests
         with:
           run: |
@@ -52,7 +52,7 @@ jobs:
       - name: Report incoming errors
         if: ${{ failure() }}
         id: slack
-        uses: slackapi/slack-github-action@v1.19.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           channel-id: '${{ secrets.SLACK_CHANNEL_ID }}'
           payload: |
@@ -98,12 +98,12 @@ jobs:
   assert_test_runner_failures:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version-file: .nvmrc
 
       - name: Install dependencies
         uses: bahmutov/npm-install@v1
@@ -120,7 +120,7 @@ jobs:
           YARN_ENABLE_IMMUTABLE_INSTALLS: false
 
       - name: Run test runner and expect failure
-        uses: mathiasvr/command-output@v1
+        uses: mathiasvr/command-output@v2.0.0
         with:
           run: |
             yarn build
@@ -147,7 +147,7 @@ jobs:
       - name: Report if any test passes
         if: ${{ always() && env.FAILED == 'true' }}
         id: slack
-        uses: slackapi/slack-github-action@v1.19.0
+        uses: slackapi/slack-github-action@v1.24.0
         with:
           channel-id: '${{ secrets.SLACK_CHANNEL_ID }}'
           payload: |

diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -7,15 +7,15 @@ jobs:
     runs-on: ubuntu-latest
     if: "!contains(github.event.head_commit.message, 'ci skip') && !contains(github.event.head_commit.message, 'skip ci') && !contains(github.event.head_commit.message, 'skip release')"
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Prepare repository
         run: git fetch --unshallow --tags
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version-file: .nvmrc
 
       - name: Install dependencies
         uses: bahmutov/npm-install@v1

diff --git a/.github/workflows/stress-test.yml b/.github/workflows/stress-test.yml
@@ -9,12 +9,12 @@ jobs:
     if: ${{ github.event.label.name == 'stress test' }}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 16.x
+          node-version-file: .nvmrc
 
       - name: Install dependencies
         uses: bahmutov/npm-install@v1
@@ -23,4 +23,4 @@ jobs:
         run: |
           yarn build
           yarn generate-dynamic-stories
-          STORY_STORE_V7=true STRESS_TEST=true yarn test-storybook:ci
+          STRESS_TEST=true yarn test-storybook:ci
diff --git a/.github/workflows/tests-extended.yml b/.github/workflows/tests-extended.yml
@@ -7,11 +7,11 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node-version: [16.x, 18.x]
+        node-version: [16.x, 18.x, 20.x]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
@@ -25,7 +25,7 @@ jobs:
       - name: Run test runner (story store v7)
         run: |
           yarn build
-          STORY_STORE_V7=true yarn test-storybook:ci
+          yarn test-storybook:ci
 
       - name: Run test runner (stories json mode)
         run: |

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -9,9 +9,9 @@ jobs:
       matrix:
         node-version: [16.x, 18.x]
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
-      - name: Use Node.js 16.x
+      - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
@@ -32,6 +32,6 @@ jobs:
           yarn test-storybook:ci-coverage
 
       - name: Generate code coverage
-        uses: codecov/codecov-action@v2
+        uses: codecov/codecov-action@v3
         with:
           verbose: true
diff --git a/.nvmrc b/.nvmrc
@@ -0,0 +1 @@
+v18
diff --git a/.storybook/main.ts b/.storybook/main.ts
@@ -33,10 +33,6 @@ const addons = [
 const config: StorybookConfig = {
   stories,
   addons,
-  features: {
-    storyStoreV7: process.env.STORY_STORE_V7 === 'false' ? false : true,
-    buildStoriesJson: true,
-  },
   core: {
     disableTelemetry: true,
   },

diff --git a/package.json b/package.json
@@ -121,7 +121,7 @@
     "ts-dedent": "^2.0.0"
   },
   "engines": {
-    "node": "^14.15.0 || ^16.10.0 || ^18.0.0 || >=20.0.0"
+    "node": "^16.10.0 || ^18.0.0 || >=20.0.0"
   },
   "auto": {
     "prereleaseBranches": [