Merge pull request #322 from zyulyaev/fix-cli-extra-args

Fix extra args not being passed to jest

src/util/getCliOptions.test.ts

@@ -2,12 +2,28 @@ import { getCliOptions } from './getCliOptions';
 import * as cliHelper from './getParsedCliOptions';
 
 describe('getCliOptions', () => {
+  let originalArgv: string[] = process.argv;
+
+  afterEach(() => {
+    process.argv = originalArgv;
+  });
+
   it('returns custom options if passed', () => {
     const customConfig = { configDir: 'custom', indexJson: true };
     jest
       .spyOn(cliHelper, 'getParsedCliOptions')
-      .mockReturnValue({ options: customConfig, extraArgs: [] });
+      .mockReturnValueOnce({ options: customConfig, extraArgs: [] });
     const opts = getCliOptions();
     expect(opts.runnerOptions).toMatchObject(customConfig);
   });
+
+  it('returns extra args if passed', () => {
+    const extraArgs = ['TestName', 'AnotherTestName'];
+    // mock argv to avoid side effect from running tests e.g. jest --coverage,
+    // which would end up caught by getCliOptions
+    process.argv = [];
+    jest.spyOn(cliHelper, 'getParsedCliOptions').mockReturnValueOnce({ options: {}, extraArgs });
+    const opts = getCliOptions();
+    expect(opts.jestOptions).toEqual(extraArgs);
+  });
 });

src/util/getCliOptions.ts

@@ -1,9 +1,7 @@
 import { getParsedCliOptions } from './getParsedCliOptions';
 import type { BrowserType } from 'jest-playwright-preset';
 
-export type JestOptions = {
-  [key: string]: any;
-};
+export type JestOptions = string[];
 
 export type CliOptions = {
   runnerOptions: {
@@ -63,7 +61,7 @@ export const getCliOptions = (): CliOptions => {
   }, defaultOptions);
 
   if (extraArgs.length) {
-    finalOptions.jestOptions.push(...[extraArgs]);
+    finalOptions.jestOptions.push(...extraArgs);
   }
 
   return finalOptions;