Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.8.0 #199

Merged
merged 12 commits into from Oct 7, 2022
Merged

Release 0.8.0 #199

merged 12 commits into from Oct 7, 2022

Commits on Sep 21, 2022

  1. Fix StorybookTestRunnerError – length on undefined 

    When running `yarn test-storybook` on my story, a 3rd party library throws an uncaught exception, but `StorybookTestRunnerError` _assumes_ `logs` is an array, which throws this error:

```console
UnhandledPromiseRejectionWarning: page.evaluate: TypeError: Cannot read properties of undefined (reading 'length')
    at new StorybookTestRunnerError (<anonymous>:58:34)
    at __throwError (<anonymous>:71:15)
    at eval (eval at evaluate (:192:30), <anonymous>:4:19)
    at UtilityScript.evaluate (<anonymous>:194:17)
    at UtilityScript.<anonymous> (<anonymous>:1:44)
```

This PR simply **defaults `logs` to `[]`**, so I can correctly see that the underlying error is _actually_ coming from a 3rd party library:

```console
 Cannot read properties of null (reading 'focus')
```
    @ericclemmons
    ericclemmons committed Sep 21, 2022
    Configuration menu
    Copy the full SHA
    13b7cf6 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2022

  1. add isTestRunner utility

    @yannbf
    yannbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    d1bba72 View commit details
    Browse the repository at this point in the history

  2. use isTestRunner in internal example

    @yannbf
    yannbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    b923816 View commit details
    Browse the repository at this point in the history

  3. update entry point for isTestRunner

    @yannbf
    yannbf committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    53a5749 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2022

  1. Fix paths to isTestRunner

    @IanVS
    IanVS committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    4010e3e View commit details
    Browse the repository at this point in the history

  2. Move to root for types/eslint

    @IanVS
    IanVS committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    ffbab9c View commit details
    Browse the repository at this point in the history

  3. undo exports map and simplify is-test-runner

    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    2a0c555 View commit details
    Browse the repository at this point in the history

  4. update docs

    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    3a52491 View commit details
    Browse the repository at this point in the history

  5. update check function

    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    719a112 View commit details
    Browse the repository at this point in the history

  6. undo is-test-runner function for now

    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    d45feb9 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #198 from storybookjs/feat/is-test-runner-utility 

    Add isTestRunner utility
    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    5e677bd View commit details
    Browse the repository at this point in the history

  8. Merge pull request #194 from ericclemmons/patch-1 

    Fix StorybookTestRunnerError – length on undefined
    @yannbf
    yannbf committed Oct 7, 2022
    Configuration menu
    Copy the full SHA
    b45bd34 View commit details
    Browse the repository at this point in the history