Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New prerelease structure / upgrade to SB7 #210

Merged
merged 10 commits into from Oct 22, 2022
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Oct 21, 2022

See README changes for details

  • Updated README
  • Upgraded SB packages to next
  • Project fixes to support SB7
  • Run in v7 mode by default (opt-out rather than opt-in)
πŸ“¦ Published PR as canary version: 0.10.0--canary.210.d43ea0e.0

✨ Test out this PR locally via:

npm install @storybook/test-runner@0.10.0--canary.210.d43ea0e.0
# or 
yarn add @storybook/test-runner@0.10.0--canary.210.d43ea0e.0

Version

Published prerelease version: v0.10.0-next.0

Changelog

πŸš€ Enhancement

πŸ› Bug Fix

Authors: 2

@shilman shilman requested a review from yannbf October 21, 2022 06:10
README.md Outdated Show resolved Hide resolved
shilman and others added 2 commits October 21, 2022 14:36
README.md Show resolved Hide resolved
@socket-security
Copy link

socket-security bot commented Oct 21, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

πŸ“œ New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
core-js-pure@3.25.5 (upgraded) postinstall package.json via @storybook/react-webpack5@7.0.0-alpha.41, @storybook/preset-react-webpack@7.0.0-alpha.41, @pmmmwh/react-refresh-webpack-plugin@0.5.8
esbuild@0.14.54 (added) postinstall package.json via @storybook/core-common@7.0.0-alpha.41
πŸ˜΅β€πŸ’« Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack.

Package Bin script Location
@storybook/cli@7.0.0-alpha.41 (added) sb package.json via storybook@7.0.0-alpha.41
storybook@7.0.0-alpha.41 (added) sb package.json
Socket.dev scan summary
Issue Status
Did you mean? βœ… no new possible package typos
Install scripts ⚠️ 2 new install scripts detected
Telemetry βœ… no new telemetry
Troll package βœ… no new troll packages
Malware βœ… no new malware
Native code βœ… no new native modules
Bin Script Confusion ⚠️ 2 new bin script confusions detected
Bin script shell injection βœ… no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@2.4.2

  • @SocketSecurity ignore core-js-pure@3.25.5
  • @SocketSecurity ignore esbuild@0.14.54
  • @SocketSecurity ignore @storybook/cli@7.0.0-alpha.41
  • @SocketSecurity ignore storybook@7.0.0-alpha.41

⚠️ Please accept the latest app permissions to ensure bot commands work properly. Accept the new permissions here.

Powered by socket.dev

@shilman shilman added the minor Increment the minor version when merged label Oct 22, 2022
@shilman shilman changed the title New prerelease structure New prerelease structure / upgrade to SB7 Oct 22, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 77.24% // Head: 76.53% // Decreases project coverage by -0.71% ⚠️

Coverage data is based on head (d43ea0e) compared to base (6bc74b4).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #210      +/-   ##
==========================================
- Coverage   77.24%   76.53%   -0.72%     
==========================================
  Files          13       11       -2     
  Lines         189      179      -10     
  Branches       41       37       -4     
==========================================
- Hits          146      137       -9     
+ Misses         43       42       -1     
Impacted Files Coverage Ξ”
src/csf/transformCsf.ts 85.71% <ΓΈ> (ΓΈ)
src/playwright/transformPlaywright.ts 100.00% <ΓΈ> (ΓΈ)
.storybook/is-test-runner.js
.storybook/preview.js

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

β˜” View full report at Codecov.
πŸ“’ Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@github-actions
Copy link

github-actions bot commented Apr 3, 2023

πŸš€ PR was released in v0.10.0 πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants