Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Add slot TS types #21359

Merged
merged 3 commits into from Mar 3, 2023
Merged

Vue3: Add slot TS types #21359

merged 3 commits into from Mar 3, 2023

Conversation

kasperpeulen
Copy link
Contributor

Closes #21221

What I did

Added slot types for Vue

How to test

  • Check if you get autocompletion for slots in Vue stories
  • Check if the slots are inserted correctly on runtime

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@kasperpeulen kasperpeulen marked this pull request as ready for review March 3, 2023 11:11
@chakAs3 chakAs3 merged commit df9fbd4 into next Mar 3, 2023
@chakAs3 chakAs3 deleted the kasper/vue-slot-types branch March 3, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Type support for Vue component slots in stories
2 participants