Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Add remount story shortcut #21401

Merged
merged 9 commits into from Apr 11, 2023
Merged

Conversation

Roel-t
Copy link
Contributor

@Roel-t Roel-t commented Mar 5, 2023

Closes #18669

What I did

  • Added shortcut for remount tool. Default is alt + R
  • Added remount tool shortcut to shortcut key bind menu.
    Screen Shot 2023-03-05 at 2 02 30 AM
  • Added remount tool shortcut tests.

How to test

Click alt + R and verify remount button animates and works.
Set new key bind to remount shortcut.
Reset key binds and verify it goes back to default.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen
Copy link
Member

Hello @Roel-t thank you for this PR, just a heads-up: it might take a little while for the core team to look at this, because the current focus is getting 7.0 shipped. We won't merge features at this time.

@yannbf yannbf changed the title feat: Remount tool shortcut UI: Add remount story shortcut Mar 16, 2023
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incredible work, @Roel-t !!! I love this 😍 thank you so so much!!

@Roel-t
Copy link
Contributor Author

Roel-t commented Mar 22, 2023

@yannbf Thank you!! So how do I go on merging the PR? I see danger JS is failing and giving npm notice created a lockfile as package-lock.json. You should commit this file. though I don't see changes to the package-lock.json file. Any idea?

@ndelangen
Copy link
Member

@Roel-t I merged in next, let's see if CI approves now.

@ndelangen ndelangen added patch:yes Bugfix & documentation PR that need to be picked to main branch and removed ci: do not merge labels Apr 11, 2023
@ndelangen ndelangen merged commit acbd015 into storybookjs:next Apr 11, 2023
60 of 61 checks passed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 11, 2023
shilman pushed a commit that referenced this pull request Apr 11, 2023
@shilman
Copy link
Member

shilman commented Apr 11, 2023

@ndelangen please don't label feature requests with the patch label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Binding a keyboard shortcut for Remount component button in toolbar
5 participants