Remove deprecated flags and properties #21852
Conversation
valentinpalkovic
added
maintenance
| @@ -243,19 +243,6 @@ function preparePartialAnnotations<TRenderer extends Renderer>( | |||
| initialArgsBeforeEnhancers | |||
| ); | |||
|
|
|||
| // Add some of our metadata into parameters as we used to do this in 6.x and users may be relying on it | |||
|
|
|||
| if (!global.FEATURES?.breakingChangesV7) { | |||
There was a problem hiding this comment.
Should this be removed? I wonder if it's needed somehow in case storyStoreV7 is false
There was a problem hiding this comment.
Is breakingChangesV7 not always true in SB 7.0 (or must be)?
There was a problem hiding this comment.
@yannbf I don't think it's necessarily to do with ssv7, just an old implementation detail that we used to store these things in parameters. We never told people to read them from there (AFAIK), but we were playing it safe in 6.x.
I think we can definitely drop this code in 7.0, but we may have missed the boat.
Not sure about breakingChangesV7 entirely. Certainly it makes sense to have gotten rid of it (I thought we already did, but it looks like @ndelangen just reversed the default). But other places it has an effect like this I am less sure of.
There was a problem hiding this comment.
I'm pretty confident this is just good to merge. We haven't heard anyone at all about this feature flag. We should have removed it prior, but the name is pretty clear in it's intent.
valentinpalkovic
force-pushed
the
valentin/remove-deprecated-apis
branch
from
23e9b51
to
ac69c94
Compare
| @@ -243,19 +243,6 @@ function preparePartialAnnotations<TRenderer extends Renderer>( | |||
| initialArgsBeforeEnhancers | |||
| ); | |||
|
|
|||
| // Add some of our metadata into parameters as we used to do this in 6.x and users may be relying on it | |||
|
|
|||
| if (!global.FEATURES?.breakingChangesV7) { | |||
There was a problem hiding this comment.
I'm pretty confident this is just good to merge. We haven't heard anyone at all about this feature flag. We should have removed it prior, but the name is pretty clear in it's intent.
| title = name; | ||
| deprecate( | ||
| '`showName` is deprecated as `name` will stop having dual purposes in the future. Please specify a `title` in `globalTypes` instead.' | ||
| ); | ||
| } else if (!showName && !icon && !title) { | ||
| } else if (!icon && !title) { |
Closes N/A
What I did
Remove deprecated flags and properties.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:mergedorci:dailyGH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]