Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Fix story data access to be more fault tolerant #21951

Merged
merged 1 commit into from Apr 5, 2023
Merged

UI: Fix story data access to be more fault tolerant #21951

merged 1 commit into from Apr 5, 2023

Conversation

ndelangen
Copy link
Member

Closes #21899

What I did

I found that the error in the issue is coming from useArgs

I wasn't able to reproduce this problem in the monorepo.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@ndelangen ndelangen self-assigned this Apr 5, 2023
@ndelangen ndelangen added the bug label Apr 5, 2023
@ndelangen ndelangen changed the title Make the access of data fault tolerant because: https://github.com/storybookjs/storybook/issues/21899#issuecomment-1497538942 Bug: fix access of data fault tolerant because Apr 5, 2023
@ndelangen ndelangen added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Apr 5, 2023
@ndelangen ndelangen requested a review from shilman April 5, 2023 15:44
shilman
shilman approved these changes Apr 5, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman added the ui label Apr 5, 2023
@shilman shilman changed the title Bug: fix access of data fault tolerant because UI: Fix story data access to be more fault tolerant Apr 5, 2023
@ndelangen ndelangen merged commit a7cf398 into next Apr 5, 2023
75 checks passed
@ndelangen ndelangen deleted the norbert/make-useargs-fault-tolerant branch April 5, 2023 22:44
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
@ndelangen @shilman
Merge pull request #21951 from storybookjs/norbert/make-useargs-fault…
f5e8534 
…-tolerant

UI: Fix story data access to be more fault tolerant
@shilman shilman mentioned this pull request Apr 11, 2023
Closed
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees

@ndelangen ndelangen

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: About page broken in built Storybooks
2 participants
@ndelangen @shilman