Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup CLI version notice #5699

Merged
merged 3 commits into from Feb 21, 2019
Merged

Cleanup CLI version notice #5699

merged 3 commits into from Feb 21, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 21, 2019

Issue: #5683

What I did

  • Clean up CLI notice now that we have a UI
  • Point to the changelog on next since it's a superset of what's on master and covers the prerelease use case

How to test

N/A

@shilman shilman added maintenance User-facing maintenance tasks cli labels Feb 21, 2019
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch release labels Feb 21, 2019
tmeasday
tmeasday approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #5699 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #5699   +/-   ##
=======================================
  Coverage   33.24%   33.24%           
=======================================
  Files         648      648           
  Lines        9363     9363           
  Branches     1355     1330   -25     
=======================================
  Hits         3113     3113           
  Misses       5635     5635           
  Partials      615      615
Impacted Files Coverage Δ
lib/core/src/server/build-dev.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 349ef25...6e23dff. Read the comment docs.

@shilman shilman merged commit 1173537 into next Feb 21, 2019
@shilman shilman deleted the 5683-cli-version-notice branch February 21, 2019 07:48
shilman added a commit that referenced this pull request Feb 21, 2019
@shilman
Merge pull request #5699 from storybooks/5683-cli-version-notice
0793417 
Cleanup CLI version notice
@shilman shilman mentioned this pull request Feb 21, 2019
Closed
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Feb 21, 2019
shilman added a commit that referenced this pull request Feb 21, 2019
@shilman
Merge pull request #5699 from storybooks/5683-cli-version-notice
cd89a16 
Cleanup CLI version notice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

@alterx alterx Awaiting requested review from alterx

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
cli maintenance User-facing maintenance tasks patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@shilman @tmeasday