Fix typo and add test

strapi · Oct 12, 2020 · e9b5cd3 · e9b5cd3
1 parent e80dd39
commit e9b5cd3
Show file tree

Hide file tree

Showing 2 changed files with 69 additions and 2 deletions.
diff --git a/packages/strapi-plugin-upload/admin/src/containers/InputModalStepperProvider/reducer.js b/packages/strapi-plugin-upload/admin/src/containers/InputModalStepperProvider/reducer.js
@@ -146,7 +146,7 @@ const reducer = (state, action) =>
         break;
       }
       case 'ON_SUBMIT_EDIT_NEW_FILE': {
-        const originalIndex = draftState.fileToEdit.originalIndex;
+        const originalIndex = state.fileToEdit.originalIndex;
         draftState.filesToUpload[originalIndex] = draftState.fileToEdit;
         draftState.fileToEdit = null;
         break;
@@ -217,7 +217,9 @@ const reducer = (state, action) =>
       }
       case 'SET_FILE_TO_EDIT': {
         draftState.fileToEdit = formatFileForEditing(
-          [...state.files, ...state.selectedFiles].find(file => file.id.toString() === action.fileId.toString())
+          [...state.files, ...state.selectedFiles].find(
+            file => file.id.toString() === action.fileId.toString()
+          )
         );
         break;
       }

diff --git a/...strapi-plugin-upload/admin/src/containers/InputModalStepperProvider/tests/reducer.test.js b/...strapi-plugin-upload/admin/src/containers/InputModalStepperProvider/tests/reducer.test.js
@@ -2250,4 +2250,69 @@ describe('UPLOAD | containers | ModalStepper | reducer', () => {
       expect(reducer(state, action)).toEqual(expected);
     });
   });
+
+  describe('ON_SUBMIT_EDIT_NEW_FILE', () => {
+    it('should update file info after edit', () => {
+      const action = {
+        type: 'ON_SUBMIT_EDIT_NEW_FILE',
+      };
+      const state = {
+        currentStep: 'edit-new',
+        fileToEdit: {
+          abortController: new AbortController(),
+          file: { name: 'test1', ok: true },
+          fileInfo: {
+            alternativeText: 'test1 alternativeText',
+            caption: 'test1 caption',
+            name: 'test1 name',
+          },
+          originalName: 'test1',
+          hasError: false,
+          errorMessage: null,
+          isUploading: false,
+          originalIndex: 0,
+          tempId: null,
+        },
+        filesToUpload: [
+          {
+            abortController: new AbortController(),
+            file: { name: 'test1', ok: true },
+            fileInfo: {
+              alternativeText: '',
+              caption: '',
+              name: 'test1',
+            },
+            originalName: 'test1',
+            hasError: false,
+            errorMessage: null,
+            isUploading: false,
+            originalIndex: 0,
+            tempId: null,
+          },
+        ],
+      };
+      const expected = {
+        currentStep: 'edit-new',
+        fileToEdit: null,
+        filesToUpload: [
+          {
+            abortController: new AbortController(),
+            file: { name: 'test1', ok: true },
+            fileInfo: {
+              alternativeText: 'test1 alternativeText',
+              caption: 'test1 caption',
+              name: 'test1 name',
+            },
+            originalName: 'test1',
+            hasError: false,
+            errorMessage: null,
+            isUploading: false,
+            originalIndex: 0,
+            tempId: null,
+          },
+        ],
+      };
+      expect(reducer(state, action)).toEqual(expected);
+    });
+  });
 });