Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible mistake about database file name in the docs (version 3.x) #6954

Closed
umutbozdag opened this issue Jul 9, 2020 · 2 comments · Fixed by #6957
Closed

Possible mistake about database file name in the docs (version 3.x) #6954

umutbozdag opened this issue Jul 9, 2020 · 2 comments · Fixed by #6957

Comments

@umutbozdag
Copy link
Contributor

Describe the bug
In this page, in the step 5 there is a mistake about database file name and i am confused about that when reading it. Isn't it should be database.js instead of database.json?

Steps to reproduce the behavior

  1. Go to this link
  2. Go to the step 5 in that page
  3. You will see that there is a mistake about database.js file name (it's database.json) in both description and note section.
@derrickmehaffy
Copy link
Member

That is correct, can you make a pull request?

@umutbozdag
Copy link
Contributor Author

That is correct, can you make a pull request?

Yeah i can do that.

umutbozdag added a commit to umutbozdag/strapi that referenced this issue Jul 9, 2020
@umutbozdag
strapi#6954 Possible mistake about database file name in the docs (ve…
5a66edf 
…rsion 3.x)
@umutbozdag umutbozdag mentioned this issue Jul 9, 2020
Merged
alexandrebodin pushed a commit that referenced this issue Jul 16, 2020
@umutbozdag @MattieBelt
#6954 Possible mistake about database file name in the docs (version … (
1d5e394 
#6957)

* #6954 Possible mistake about database file name in the docs (version 3.x)

* Update docs/v3.x/guides/databases.md

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this issue Aug 13, 2020
@umutbozdag @MattieBelt @onepointconsulting
strapi#6954 Possible mistake about database file name in the docs (ve…
9718a77 
…rsion … (strapi#6957)

* strapi#6954 Possible mistake about database file name in the docs (version 3.x)

* Update docs/v3.x/guides/databases.md

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#6954 Possible mistake about database file name in the docs (version … umutbozdag/strapi
2 participants
@derrickmehaffy @umutbozdag