Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6954 Possible mistake about database file name in the docs (version … #6957

Merged
merged 3 commits into from Jul 16, 2020

Conversation

umutbozdag
Copy link
Contributor

@umutbozdag umutbozdag commented Jul 9, 2020

Description of what you did:

I have changed the confusing file names to database.js from database.json and removed unnecessary double quotes since it is a JavaScript file.

@codecov
Copy link

codecov bot commented Jul 9, 2020

Codecov Report

Merging #6957 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6957   +/-   ##
=======================================
  Coverage   20.05%   20.05%           
=======================================
  Files         858      858           
  Lines       12049    12049           
  Branches     1951     1951           
=======================================
  Hits         2416     2416           
  Misses       8062     8062           
  Partials     1571     1571           
Flag Coverage Δ
#front 14.67% <ø> (ø)
#unit 42.45% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3e078c...28751fa. Read the comment docs.

derrickmehaffy
derrickmehaffy previously approved these changes Jul 9, 2020
Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for your help 💯

@alexandrebodin alexandrebodin added this to the 3.0.6 milestone Jul 16, 2020
@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Jul 16, 2020
@alexandrebodin alexandrebodin merged commit 1d5e394 into strapi:master Jul 16, 2020
@umutbozdag umutbozdag deleted the patch-1 branch July 16, 2020 09:45
gilfernandes pushed a commit to onepointconsulting/strapi that referenced this pull request Aug 13, 2020
…rsion … (strapi#6957)

* strapi#6954 Possible mistake about database file name in the docs (version 3.x)

* Update docs/v3.x/guides/databases.md

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>

Co-authored-by: Mattias van den Belt <mattiasvandenbelt@gmail.com>
Signed-off-by: Gil Fernandes <gil.fernandes@onepointltd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible mistake about database file name in the docs (version 3.x)
4 participants