Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/i18n-superAdminRole #10171

Merged
merged 1 commit into from
Apr 28, 2021
Merged

fix/i18n-superAdminRole #10171

merged 1 commit into from
Apr 28, 2021

Conversation

markkaylor
Copy link
Contributor

What does it do?

Returns early if a superAdminRole does not exist

Why is it needed?

Throws an error in bootstrap function when creating a locale

How to test it?

Create a locale in the bootstrap function

  await strapi.query("locale", "i18n").create({
    name: "French (fr)",
    code: "fr",
  });

@markkaylor markkaylor self-assigned this Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #10171 (1e0a849) into master (dfe8edb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10171   +/-   ##
=======================================
  Coverage   60.06%   60.06%           
=======================================
  Files         183      183           
  Lines        5702     5702           
  Branches     1077     1077           
=======================================
  Hits         3425     3425           
  Misses       1817     1817           
  Partials      460      460           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 60.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe8edb...1e0a849. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: plugin:i18n Source is plugin/i18n package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants