Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #10187 #10193

Merged
merged 1 commit into from
May 7, 2021
Merged

Fixes #10187 #10193

merged 1 commit into from
May 7, 2021

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril.lpz@gmail.com

What does it do?

It displays the name of the custom field in the content type builder list-view.

Fixes #10187

Signed-off-by: soupette <cyril.lpz@gmail.com>
@soupette soupette added issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package labels Apr 30, 2021
@soupette soupette added this to the 3.6.2 milestone Apr 30, 2021
@soupette soupette requested a review from mfrachet April 30, 2021 06:34
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #10193 (84cd836) into master (2fd2904) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10193   +/-   ##
=======================================
  Coverage   60.06%   60.06%           
=======================================
  Files         183      183           
  Lines        5702     5702           
  Branches     1077     1077           
=======================================
  Hits         3425     3425           
  Misses       1817     1817           
  Partials      460      460           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 60.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd2904...84cd836. Read the comment docs.

Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Field in Plugin produces i18n missing translation error.
4 participants