Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing positive requirement of integer validation #10269

Merged
merged 2 commits into from
May 11, 2021

Conversation

multiwebinc
Copy link
Contributor

Fixes #10179. It seems to be working for me locally, but I didn't run any tests.

What does it do?

Removes the requirement for integers to be positive

Why is it needed?

Because there's no reason an integer can't be zero or negative

@strapi-cla
Copy link

strapi-cla commented May 10, 2021

CLA assistant check
All committers have signed the CLA.

@derrickmehaffy derrickmehaffy marked this pull request as ready for review May 10, 2021 20:02
@derrickmehaffy derrickmehaffy added the issue: bug Issue reporting a bug label May 10, 2021
@derrickmehaffy derrickmehaffy added this to the 3.6.2 milestone May 10, 2021
@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #10269 (1302998) into master (436d9fd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10269   +/-   ##
=======================================
  Coverage   57.82%   57.82%           
=======================================
  Files         184      184           
  Lines        6393     6393           
  Branches     1395     1395           
=======================================
  Hits         3697     3697           
  Misses       2233     2233           
  Partials      463      463           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436d9fd...1302998. Read the comment docs.

@alexandrebodin alexandrebodin removed this from the 3.6.2 milestone May 11, 2021
@alexandrebodin alexandrebodin added the source: core:content-type-builder Source is core/content-type-builder package label May 11, 2021
Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:content-type-builder Source is core/content-type-builder package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with the minimum value on Integer Number field
5 participants