-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing positive requirement of integer validation #10269
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10269 +/- ##
=======================================
Coverage 57.82% 57.82%
=======================================
Files 184 184
Lines 6393 6393
Branches 1395 1395
=======================================
Hits 3697 3697
Misses 2233 2233
Partials 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you for your contribution
Fixes #10179. It seems to be working for me locally, but I didn't run any tests.
What does it do?
Removes the requirement for integers to be positive
Why is it needed?
Because there's no reason an integer can't be zero or negative