Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility issue for mongo < 4.2 #10281

Merged
merged 1 commit into from
May 11, 2021

Conversation

Convly
Copy link
Member

@Convly Convly commented May 10, 2021

What does it do?

Fix usage of model.updateOne in admin migration to ensure compatibility with mongo < 4.2.

Why is it needed?

Aggregate (array) parameter is not available for model.updateOne until mongo 4.2.

Related issue(s)/PR(s)

should fix #10096

@Convly Convly added issue: bug Issue reporting a bug source: core:database Source is core/database package labels May 10, 2021
@Convly Convly added this to the 3.6.2 milestone May 10, 2021
Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 10, 2021

Codecov Report

Merging #10281 (d27b590) into master (436d9fd) will not change coverage.
The diff coverage is n/a.

❗ Current head d27b590 differs from pull request most recent head 155220e. Consider uploading reports for the commit 155220e to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10281   +/-   ##
=======================================
  Coverage   57.82%   57.82%           
=======================================
  Files         184      184           
  Lines        6393     6393           
  Branches     1395     1395           
=======================================
  Hits         3697     3697           
  Misses       2233     2233           
  Partials      463      463           
Flag Coverage Δ
front ∅ <ø> (∅)
unit 57.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 436d9fd...155220e. Read the comment docs.

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: core:database Source is core/database package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrating 3.6.0 now is not starting; downgrading 3.5.4 solves the issue
3 participants