change common beginning to common path

[tonny008]

What does it do?

Change common beginning to common path

Why is it needed?

server.js
url: http://example.com/api
admin.url http://example.com/admin

use common beginning the admin path will be dmin

[strapi-cla]

All committers have signed the CLA.

[petersg83]

Hi :)
Thanks for your contribution. The code can be improved indeed.

I read your code, here is a proposition of something even shorter and generic:

const getCommonBeginning = (...strings) => takeWhile(
  strings[0],
  (char, index) => strings.every(string => string[index] === char)
).join('');

Can you directly change the function getCommonBeginning in /packages/core/utils/lib/string-formatting.js?
Also can you add some tests for this function in /packages/core/utils/lib/__tests__/string-formatting.test.js?

[tonny008]

I don’t think it’s common beginnings here.

Given:
http://example.com/api
http://example.com/admin

common beginnings is http://example.com/a,
Common path is http://example.com

use common beginning the admin path will be dmin

[petersg83]

You're right I didn't see that. Thank you.
Can you please move the function next to commonBeginning in /packages/core/utils/lib/string-formatting.js?
And if you have time to write a few tests in /packages/core/utils/lib/__tests__/string-formatting.test.js, it would be perfect.
Otherwise I can do it too

[petersg83]

Thank you, you did everything :D
I proposed a couple more tests. What do you think?

[petersg83]

It looks good to me! Thank you for this contribution!

[codecov]

Codecov Report

Merging #10509 (109b933) into master (1c424ad) will increase coverage by 0.11%.
The diff coverage is 88.88%.

❗ Current head 109b933 differs from pull request most recent head ce51257. Consider uploading reports for the commit ce51257 to get more accurate results

@@            Coverage Diff             @@
##           master   #10509      +/-   ##
==========================================
+ Coverage   58.01%   58.12%   +0.11%     
==========================================
  Files         185      185              
  Lines        6431     6429       -2     
  Branches     1398     1395       -3     
==========================================
+ Hits         3731     3737       +6     
+ Misses       2236     2230       -6     
+ Partials      464      462       -2     

Flag	Coverage Δ
front	∅ <ø> (∅)
unit	58.12% <88.88%> (+0.11%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
packages/strapi-utils/lib/config.js	60.46% <50.00%> (ø)
packages/strapi-utils/lib/string-formatting.js	100.00% <100.00%> (+40.00%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c424ad...ce51257. Read the comment docs.

[alexandrebodin]

Hi there 👋 Do you think you will be able to finish the changes requested at some point ?