Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Starter CLI] fix has-yarn #10532

Merged
merged 2 commits into from Jun 23, 2021
Merged

[Starter CLI] fix has-yarn #10532

merged 2 commits into from Jun 23, 2021

Conversation

markkaylor
Copy link
Contributor

What does it do?

Fixes #10516

Why is it needed?

The function to check for yarn was not being invoked and always resolving to true

execa.shellSync has been removed
sindresorhus/execa#219

@markkaylor markkaylor self-assigned this Jun 23, 2021
@codecov
Copy link

codecov bot commented Jun 23, 2021

Codecov Report

Merging #10532 (5499e84) into master (aebdb33) will not change coverage.
The diff coverage is n/a.

❗ Current head 5499e84 differs from pull request most recent head 50f03f8. Consider uploading reports for the commit 50f03f8 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10532   +/-   ##
=======================================
  Coverage   58.01%   58.01%           
=======================================
  Files         185      185           
  Lines        6431     6431           
  Branches     1400     1400           
=======================================
  Hits         3731     3731           
  Misses       2236     2236           
  Partials      464      464           
Flag Coverage Δ
front ?
unit 58.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aebdb33...50f03f8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: bug Issue reporting a bug source: cli Source is cli package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strapi-starter nuxt-blog npm installation doesn't work
2 participants