add marketplace banner that links to strapi awesome #10677
Conversation
Codecov Report
@@ Coverage Diff @@
## master #10677 +/- ##
=======================================
Coverage 58.01% 58.01%
=======================================
Files 185 185
Lines 6431 6431
Branches 1398 1398
=======================================
Hits 3731 3731
Misses 2236 2236
Partials 464 464
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
| border-left: 4px solid #317ff6; | ||
| box-shadow: 0 2px 4px #e3e9f3; |
There was a problem hiding this comment.
These two colors don't exist in the current theme nor in the @strapi/parts design system. IMO we should use some existing colors.
| const PluginBanner = () => { | ||
| return ( | ||
| <Wrapper> | ||
| <img className="bannerImage" src={LogoStrapi} alt="A strapi rocket logo" /> |
There was a problem hiding this comment.
I think the alt message should be translated.
There was a problem hiding this comment.
as you did for the <FormattedMessage id="app.components.PluginBanner" />
| rel="noopener noreferrer" | ||
| className="bannerLink" | ||
| > | ||
| Check it out now |
There was a problem hiding this comment.
Same here, this message should be translated
| @@ -0,0 +1,28 @@ | |||
| import styled from 'styled-components'; | |||
|
|
|||
| const Wrapper = styled.div` | |||
There was a problem hiding this comment.
Some of the CSS values are used in @strapi/parts. Can you put a comment here to avoid forgetting to migrate this component please?
// TODO : To migrate with @strapi/parts
alexandrebodin
added
source: core:admin
What does it do?
Adds a banner on the marketplace page that links to strapi awesome: https://github.com/strapi/awesome-strapi
Why is it needed?
Helps people find community plugins
How to test it?
Run strapi admin locally and go to the marketplace page