Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplified Chinese Translation Completed #10680

Merged
merged 21 commits into from
Dec 2, 2021

Conversation

huangyuzhang
Copy link

@huangyuzhang huangyuzhang commented Aug 3, 2021

What does it do?

Corrected some issues related to locales and added some missing ones.
Completed the Simplified Chinese Translation for all plugins.
Edit since 3.6.6: imporved the wording of Chinese translation, as well as the naming of locale id.

Why is it needed?

The current Chinese translation is out-dated and some concepts could be incomprehensible (e.g. Collection Type v.s. Single Type) for many Chinese speakers. This pull request not only completed the Chinese translation locales related to the admin panel, but also added some missing locales in english and code in the font-end files.

How to test it?

No new function or method added.
zh-Hans.json files were populated according to the en.json.
formatMessage() & getTrad() were used for the missing ones.

Related issue(s)/PR(s)

NA

HichamELBSI
HichamELBSI previously approved these changes Aug 18, 2021
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @huangyuzhang, Thanks for your contribution. It seems to be good for me. You just need to update your branch and then we will be able to merge it 😃

@alexandrebodin alexandrebodin added the source: core:admin Source is core/admin package label Sep 1, 2021
@alexandrebodin alexandrebodin added this to the 3.6.9 milestone Sep 1, 2021
@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #10680 (db31902) into master (d91569c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10680   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d91569c...db31902. Read the comment docs.

@alexandrebodin alexandrebodin changed the base branch from master to releases/v3.6.9 December 2, 2021 14:29
@alexandrebodin alexandrebodin dismissed HichamELBSI’s stale review December 2, 2021 14:29

The base branch was changed.

@alexandrebodin alexandrebodin merged commit 1f0ec43 into strapi:releases/v3.6.9 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants