Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tracking event to strapi awesome banner #10701

Merged
merged 2 commits into from
Aug 18, 2021

Conversation

markkaylor
Copy link
Contributor

What does it do?

Adds a tracking event to the strapi awesome marketplace banner

@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #10701 (774af7e) into master (7a80bda) will not change coverage.
The diff coverage is n/a.

❗ Current head 774af7e differs from pull request most recent head e122a33. Consider uploading reports for the commit e122a33 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10701   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a80bda...e122a33. Read the comment docs.

import { FormattedMessage, useIntl } from 'react-intl';
import Wrapper from './Wrapper';
import LogoStrapi from '../../../assets/images/banner_strapi-rocket.png';

const PluginBanner = () => {
const PluginBanner = ({ emitEvent }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The emitEvent function isn't used to define the Banner component. IMO this component shouldn't depend on this kind of props. Can you get the emitEvent from the global context please.

import { useGlobalContext } from 'strapi-helper-plugin';

const { emitEvent } = useGlobalContext();

emitEvent('didGoToStrapiAwesome');

@markkaylor markkaylor force-pushed the chore/strapi-awesome-tracking branch from a124be6 to abb0a6b Compare August 17, 2021 13:29
Copy link
Contributor

@HichamELBSI HichamELBSI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markkaylor markkaylor merged commit c3eff49 into master Aug 18, 2021
@markkaylor markkaylor deleted the chore/strapi-awesome-tracking branch August 18, 2021 09:12
@alexandrebodin alexandrebodin added this to the 3.6.7 milestone Aug 18, 2021
@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants