-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Landing page social links #10766
Conversation
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@Melanie12 we still have a very active community on Reddit (and a few team members as mods there, myself included). |
Codecov Report
@@ Coverage Diff @@
## master #10766 +/- ##
=======================================
Coverage 58.12% 58.12%
=======================================
Files 185 185
Lines 6429 6429
Branches 1395 1395
=======================================
Hits 3737 3737
Misses 2230 2230
Partials 462 462
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
LGTM |
@derrickmehaffy No problem. I thought Reddit was a distraction from the forum. @KevinCudennec do you think we need to create new logos for career or blog? So it's less repetitive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good for me.
I guess we can change the logos later when we have an idea of the design.
Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com
What does it do?
Why is it needed?
How to test it?
Standard testing of admin PRs
Related issue(s)/PR(s)
fixes #10758