Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Landing page social links #10766

Merged
merged 1 commit into from
Aug 24, 2021
Merged

Update Landing page social links #10766

merged 1 commit into from
Aug 24, 2021

Conversation

derrickmehaffy
Copy link
Member

@derrickmehaffy derrickmehaffy commented Aug 19, 2021

Signed-off-by: Derrick Mehaffy derrickmehaffy@gmail.com

What does it do?

  • Replaces Slack with Discord
  • Replaces Medium with Blog
  • Replaces Academy with Careers

Why is it needed?

  • We don't have a community slack anymore
  • We no longer push content to medium
  • Academy is being put in limbo

How to test it?

Standard testing of admin PRs

Related issue(s)/PR(s)

fixes #10758

image

image

Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
@derrickmehaffy derrickmehaffy added this to the 3.6.8 milestone Aug 19, 2021
@derrickmehaffy derrickmehaffy self-assigned this Aug 19, 2021
@derrickmehaffy
Copy link
Member Author

@Melanie12 we still have a very active community on Reddit (and a few team members as mods there, myself included).
I also changed Hiring to Careers, let me know if this works for you.

@codecov
Copy link

codecov bot commented Aug 19, 2021

Codecov Report

Merging #10766 (c9b1540) into master (5202c4e) will not change coverage.
The diff coverage is n/a.

❗ Current head c9b1540 differs from pull request most recent head a46cb75. Consider uploading reports for the commit a46cb75 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10766   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5202c4e...a46cb75. Read the comment docs.

@soupette soupette removed the request for review from HichamELBSI August 20, 2021 05:59
@soupette
Copy link
Contributor

LGTM

@Melanie12
Copy link

@derrickmehaffy No problem. I thought Reddit was a distraction from the forum.
Thank you for your help.

@KevinCudennec do you think we need to create new logos for career or blog? So it's less repetitive.

Copy link

@Melanie12 Melanie12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me.
I guess we can change the logos later when we have an idea of the design.

@alexandrebodin alexandrebodin added source: core:admin Source is core/admin package issue: enhancement Issue suggesting an enhancement to an existing feature labels Aug 24, 2021
@alexandrebodin alexandrebodin merged commit e69ab29 into master Aug 24, 2021
@alexandrebodin alexandrebodin deleted the feature/socialLogos branch August 24, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] Change Logos and links
4 participants