-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump sharp to 0.29.0 #10800
bump sharp to 0.29.0 #10800
Conversation
Changelog for Sharp here: https://sharp.pixelplumbing.com/changelog#v0290---17th-august-2021
No breaking changes, although we are in a change freeze I don't see why we couldn't merge this. |
Waiting for tests to pass before requesting review |
Codecov Report
@@ Coverage Diff @@
## master #10800 +/- ##
=======================================
Coverage 58.12% 58.12%
=======================================
Files 185 185
Lines 6429 6429
Branches 1395 1395
=======================================
Hits 3737 3737
Misses 2230 2230
Partials 462 462
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you
What does it do?
Upgrades sharp dependency in strapi-plugin-upload to latest stable version (0.29.0).
Why is it needed?
In some cases, width and height could not be determined for PNG images as sharp threw an error (
Input buffer has corrupt header: pngload_buffer: invalid chunk position
). This also prevented strapi-plugin-upload from generating different image sizes/formats.The latest sharp version no longer has this issue.
How to test it?
--
Related issue(s)/PR(s)
--