Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the test section of the CONTRIBUTRING file. #10848

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

Elhebert
Copy link
Contributor

@Elhebert Elhebert commented Sep 1, 2021

What does it do?

This PR adds more clarity in how to run the e2e test suite. It also document how to run the tests only for CE or how to add a license to run the tests in EE.

Why is it needed?

The current CONTRIBUTING guide isn't very explicit on how to run the e2e tests suite, which can cause some issues as the information is hard to find in the code base.

How to test it?

N/A

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@codecov
Copy link

codecov bot commented Sep 1, 2021

Codecov Report

Merging #10848 (ab9221a) into master (8972d78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10848   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         185      185           
  Lines        6429     6429           
  Branches     1395     1395           
=======================================
  Hits         3737     3737           
  Misses       2230     2230           
  Partials      462      462           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8972d78...ab9221a. Read the comment docs.

Copy link
Contributor

@oiorain oiorain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. LGTM!

@alexandrebodin alexandrebodin added source: docs Documentation changes issue: enhancement Issue suggesting an enhancement to an existing feature labels Sep 1, 2021
@alexandrebodin alexandrebodin added this to the 3.6.9 milestone Sep 1, 2021
@alexandrebodin alexandrebodin merged commit d36e41d into master Sep 1, 2021
@alexandrebodin alexandrebodin deleted the docs/improve-test-section branch September 1, 2021 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants