Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add current password requirement to edit own profile password #11992

Merged
merged 2 commits into from
Jan 12, 2022

Conversation

soupette
Copy link
Contributor

Signed-off-by: soupette cyril@strapi.io

What does it do?

Add current password input to update a user credentials

Signed-off-by: soupette <cyril@strapi.io>
@soupette soupette requested a review from Convly December 22, 2021 14:04
@soupette soupette added this to the 3.6.9 milestone Dec 22, 2021
@Convly Convly force-pushed the security-check-password-update branch from 49ca751 to 0bf01ef Compare January 12, 2022 15:04
@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #11992 (975ab39) into releases/v3.6.9 (8972d78) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           releases/v3.6.9   #11992      +/-   ##
===================================================
- Coverage            58.12%   58.12%   -0.01%     
===================================================
  Files                  185      185              
  Lines                 6429     6431       +2     
  Branches              1395     1396       +1     
===================================================
+ Hits                  3737     3738       +1     
  Misses                2230     2230              
- Partials               462      463       +1     
Flag Coverage Δ
front ?
unit 58.12% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-admin/validation/user.js 83.33% <50.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8972d78...975ab39. Read the comment docs.

Copy link
Member

@Convly Convly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Convly Convly added issue: security Issue reporting a security problem source: core:admin Source is core/admin package labels Jan 12, 2022
@Convly Convly merged commit 53e8381 into releases/v3.6.9 Jan 12, 2022
@Convly Convly deleted the security-check-password-update branch January 12, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: security Issue reporting a security problem source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants