Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Enable to trigger empty events webhook #12192

Conversation

Convly
Copy link
Member

@Convly Convly commented Jan 13, 2022

Same as #12174 but for the V3

@Convly Convly added issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package labels Jan 13, 2022
@Convly Convly added this to the 3.6.9 milestone Jan 13, 2022
@Convly Convly requested a review from soupette January 13, 2022 15:21
@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #12192 (13f37e9) into releases/v3.6.9 (db31902) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           releases/v3.6.9   #12192      +/-   ##
===================================================
- Coverage            58.12%   58.12%   -0.01%     
===================================================
  Files                  185      185              
  Lines                 6429     6431       +2     
  Branches              1395     1396       +1     
===================================================
+ Hits                  3737     3738       +1     
  Misses                2230     2230              
- Partials               462      463       +1     
Flag Coverage Δ
unit 58.12% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/strapi-admin/validation/user.js 83.33% <50.00%> (-4.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53e8381...13f37e9. Read the comment docs.

Copy link
Contributor

@soupette soupette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: core:admin Source is core/admin package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants