Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V3] Packages Deprecation #12520

Merged
merged 3 commits into from
Feb 14, 2022
Merged

Conversation

Convly
Copy link
Member

@Convly Convly commented Feb 14, 2022

What does it do?

As we released Strapi V4 and are about to reach end-of-support for Strapi V3 (around Q3 2022).
We decided to add a deprecation notice to the concerned packages so that users can be warned in advance about what's going to happen.

Packages will either:

  • Not going to change at all (no deprecation warning)
  • Be moved to another package (deprecation warning + link to the V4 version of the package)
  • Be deleted (deprecation warning + notice of no further support)

Why is it needed?

We want to prepare the migration from V3 to V4 the best we can, and it includes warning the community as soon as possible about the changes that are about to come.

How to test it?

Open some packages readme (strapi, strapi-hook-ejs, strapi-plugin-graphql) files and... read them 🤷

@Convly Convly added issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes labels Feb 14, 2022
@Convly Convly added this to the 3.6.9 milestone Feb 14, 2022
@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #12520 (dff93d0) into releases/v3.6.9 (13f37e9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           releases/v3.6.9   #12520   +/-   ##
================================================
  Coverage            58.12%   58.12%           
================================================
  Files                  185      185           
  Lines                 6431     6431           
  Branches              1396     1396           
================================================
  Hits                  3738     3738           
  Misses                2230     2230           
  Partials               463      463           
Flag Coverage Δ
front ?
unit 58.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e3a134...dff93d0. Read the comment docs.

Copy link
Member

@alexandrebodin alexandrebodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The timing ain't right but the rest is good :)

packages/strapi-admin/README.md Outdated Show resolved Hide resolved
@alexandrebodin alexandrebodin merged commit e1cb927 into releases/v3.6.9 Feb 14, 2022
@alexandrebodin alexandrebodin deleted the packages-deprecation branch February 14, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue: enhancement Issue suggesting an enhancement to an existing feature source: docs Documentation changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants