Add better-sqlite3 dialect as alternative to @vscode/sqlite3 #12559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
Signed-off-by: Derrick Mehaffy <derrickmehaffy@gmail.com>
derrickmehaffy
added
issue: enhancement
Codecov Report
@@ Coverage Diff @@
## master #12559 +/- ##
==========================================
- Coverage 47.59% 47.58% -0.01%
==========================================
Files 210 210
Lines 8192 8193 +1
Branches 1857 1858 +1
==========================================
Hits 3899 3899
- Misses 3531 3532 +1
Partials 762 762
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
alexandrebodin
added
pr: enhancement
|
Closing and merging this into #12557 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires this PR to be merged first: #12557
Since the status of Mapbox's
node-sqlite3is a bit up in the air and Knex removed support for it (swapped for@vscode/sqlite3). Knex did add support forbetter-sqlite3which has been a very stable replacement for both.References:
better-sqlite3Driver knex/knex#4871I do not plan to add these as choices for users to pick from when creating new projects as these should be considered unstable. If all goes well in testing maybe in Strapi v5 we can depreciate the
sqliteclient and dialect and only usebetter-sqlite3but we will need to validate this as it could be a breaking change if APIs change.To-Do: