chore: Update jest packages to v29 #14221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gu-stav
added
source: tooling
Codecov Report
@@ Coverage Diff @@
## main #14221 +/- ##
==========================================
+ Coverage 55.44% 57.55% +2.11%
==========================================
Files 1274 1262 -12
Lines 31859 30689 -1170
Branches 5750 5747 -3
==========================================
Hits 17664 17664
+ Misses 12372 11205 -1167
+ Partials 1823 1820 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
If I remember correctly we add a pbl with v28. Was it fixed with v29? |
|
@alexandrebodin yes I've mentioned the problem and the fix in the PR description. Everything seems to work now. |
gu-stav
changed the title
alexandrebodin
previously approved these changes
Aug 25, 2022
gu-stav
force-pushed
the
chore/jest-29
branch
2 times, most recently
from
1e9e4a3
to
9aea302
Compare
alexandrebodin
previously approved these changes
Aug 26, 2022
alexandrebodin
previously approved these changes
Aug 29, 2022
alexandrebodin
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
This updates jest related dependencies to version 29. A previous attempt to update jest@28 didn't work, because we were blocked on a babel-issue that is resolved in v29.
Jest updated the snapshot format slightly, which is why some of them changed: https://jestjs.io/blog/2022/08/25/jest-29
Why is it needed?
Update dependencies.
How to test it?
Jest tests itself.
Related issue(s)/PR(s)