Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 dependencies #14914

Merged
merged 10 commits into from
Nov 22, 2022
Merged

v3 dependencies #14914

merged 10 commits into from
Nov 22, 2022

Conversation

alexandrebodin
Copy link
Member

@alexandrebodin alexandrebodin commented Nov 17, 2022

What does it do?

Continues work started in #14725.

Why is it needed?

To fix some dep security vulnerabilities

How to test it?

yarn setup & run the getstarted

Related issue(s)/PR(s)

Let us know if this is related to any issue/pull request

@alexandrebodin alexandrebodin changed the title wip v3 dependencies Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (releases/3.6.11@86f882b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 7215c92 differs from pull request most recent head ba3552d. Consider uploading reports for the commit ba3552d to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##             releases/3.6.11   #14914   +/-   ##
==================================================
  Coverage                   ?   58.20%           
==================================================
  Files                      ?      185           
  Lines                      ?     6443           
  Branches                   ?     1404           
==================================================
  Hits                       ?     3750           
  Misses                     ?     2230           
  Partials                   ?      463           
Flag Coverage Δ
front ∅ <0.00%> (?)
unit 58.20% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@derrickmehaffy derrickmehaffy added source: dependencies Source is dependency problem pr: security This PR is security issue labels Nov 18, 2022
@derrickmehaffy derrickmehaffy added this to the 3.6.11 milestone Nov 18, 2022
@alexandrebodin alexandrebodin marked this pull request as ready for review November 21, 2022 14:35
@derrickmehaffy
Copy link
Member

Changelog

  • Removed node 12 tests
  • git-url-parse: 11.4.4 -> 13.1.0
  • immer: ^8.0.1 -> 9.0.16
  • koa-passport: 4.1.4 -> 5.0.0
  • moment: ^2.29.1 -> ^2.29.4
  • sanitize-html: 2.3.3 -> 2.7.2
  • sharp: 0.29.0 -> 0.31.1
  • package-json: 6.5.0 -> 7.0.0 (this may not fix all the vulns but we can't upgrade further as they have gone full ESM-only)
  • Several nested dependencies updated as a result of these upgrades
  • Decreased total number of vulnerabilities from ~430 to 392
    • v3.6.10: 10 Low | 131 Moderate | 233 High | 57 Critical
    • v3.6.11: 10 Low | 113 Moderate | 220 High | 49 Critical

Packages we will not upgrade in v3

Breaking changes

  • swagger-ui-dist: Breaks application during upgrade, too much effort required to upgrade
  • mongoose: Breaks application during upgrade, too much effort required to upgrade
  • package-json: Converted to ESM only, breaking changes
  • mailgun-js: Package no longer maintained, replacement has far too many breaking changes to backport updates in v4
  • axios: Breaks application during upgrade, too much effort required to upgrade
  • graphql-upload: Breaks application during upgrade, too much effort required to upgrade, package moved to ESM only
  • koa-router: Breaks application during upgrade, too much effort required to upgrade
  • apollo-server-koa: Breaks application during upgrade, too much effort required to upgrade

Exploitation not possible

  • enzyme: Exploitation not possible in our use-case or in production deployments
  • cheerio: Exploitation not possible in our use-case or in production deployments
  • autoprefixer: Exploitation not possible in our use-case or in production deployments
  • css-loader: Exploitation not possible in our use-case or in production deployments
  • postcss: Exploitation not possible in our use-case or in production deployments
  • markdown-it: Exploitation not possible in our use-case or in production deployments
  • draft-js: Exploitation not possible in our use-case or in production deployments
  • request: Exploitation not possible in our use-case or in production deployments
  • node-schedule: Exploitation not possible in our use-case or in production deployments
  • mini-css-extract-plugin: Exploitation not possible in our use-case or in production deployments
  • file-loader: Exploitation not possible in our use-case or in production deployments
  • babel-eslint: Exploitation not possible in our use-case or in production deployments
  • eslint-import-resolver-node: Exploitation not possible in our use-case or in production deployments
  • tsconfig-paths: Exploitation not possible in our use-case or in production deployments
  • babel-loader: Exploitation not possible in our use-case or in production deployments
  • yargs: Exploitation not possible in our use-case or in production deployments
  • webpack-dev-server: Exploitation not possible in our use-case or in production deployments
  • webpack: Exploitation not possible in our use-case or in production deployments
  • html-webpack-plugin: Exploitation not possible in our use-case or in production deployments
  • webpack-cli: Exploitation not possible in our use-case or in production deployments
  • inquirer: Exploitation not possible in our use-case or in production deployments
  • friendly-errors-webpack-plugin: Exploitation not possible in our use-case or in production deployments
  • node-fetch: Only used in limited places in the code-base that bad actors cannot interact with

Repo Management

  • husky: Doesn't impact projects, only repo management
  • stylelint: Doesn't impact projects, only repo management
  • jest-circus: Doesn't impact projects, only repo management
  • jest-cli: Doesn't impact projects, only repo management
  • jest: Doesn't impact projects, only repo management
  • lerna: Doesn't impact projects, only repo management
  • snyk: Doesn't impact projects, only repo management

No longer maintained

  • ejs: Package (strapi-hook-ejs) isn't used and isn't recommended for usage
  • pkgcloud: Only used by the rackspace provider which we have cut all ties with

Copy link
Member

@derrickmehaffy derrickmehaffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexandrebodin alexandrebodin removed the request for review from gu-stav November 22, 2022 09:56
@alexandrebodin alexandrebodin merged commit d8ca7ff into releases/3.6.11 Nov 22, 2022
@alexandrebodin alexandrebodin deleted the chore/v3-deps branch November 22, 2022 15:23
@derrickmehaffy
Copy link
Member

(Thanks Alex lol)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: security This PR is security issue source: dependencies Source is dependency problem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants